Review Request 127462: Add support for get QStandardPaths locations.

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review94075
-----------------------------------------------------------



LGTM.  Two minor issues with the documentation, then it is good to go in.  Please also add a CHANGELOG line to the commit message.  Thanks for taking care of this.


docs/options.md (line 94)
<https://git.reviewboard.kde.org/r/127462/#comment64058>

    Grammer nitpick, maybe instead:
    
    There are three environment variables that have a fallback strategy if the
    environment variable is not set. They instead map to a location from QStanardPaths.  They are:



docs/options.md (line 96)
<https://git.reviewboard.kde.org/r/127462/#comment64059>

    Nitpick: s/QStandardsPath/QStandardPaths/


- Matthew Dawson


On March 28, 2016, 11:21 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 11:21 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Inside desktop files we want to reach also data, cache and config home
> to create files inside these directories.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> -------
> 
> Adding tests for QT_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160328/76340374/attachment.html>