Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127497/#review94022
-----------------------------------------------------------



This issue was just fixed by Kare, see kwrite-devel mailing list and commit
https://quickgit.kde.org/?p=ktexteditor.git&a=commit&h=f7f330b21aa394a62ac95ea9bee075f372ff6d9c

A bug was introduced in clazy commits, unfortunately, this bug is also in the latest frameworks release.

Thanks for looking into this, though.
However, since this is fixed now, please discard this review request, the code is correct as is.

- Dominik Haumann


On March 26, 2016, 7:23 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127497/
> -----------------------------------------------------------
> 
> (Updated March 26, 2016, 7:23 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Selection must be cleared with redraw. Below comment says: "don't redraw the cleared selection - that's done in editEnd()." -> this is not true, i don't see any code to clear selection, i may wrong
> 
> 
> Diffs
> -----
> 
>   src/view/kateview.cpp aadc42b 
> 
> Diff: https://git.reviewboard.kde.org/r/127497/diff/
> 
> 
> Testing
> -------
> 
> Screenshot to prove
> 
> 
> File Attachments
> ----------------
> 
> Selection stays above and below cursor line
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/26/8154d84d-d858-46c1-956b-290ea604984a__Screenshot_20160326_091738.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160326/c190c94a/attachment.html>