Review Request 127462: Add support for XDG_*_HOME enviroment variables.

[Sandro Knauß]

> On März 24, 2016, 8:16 vorm., David Faure wrote:
> > autotests/kconfigtest.cpp, line 536
> > <https://git.reviewboard.kde.org/r/127462/diff/1/?file=453758#file453758line536>
> >
> >     Why? On my system this wouldn't pass.
> >     If you want to make sure it's empty, use qunsetenv.

Okay I mostly written this, to get a first impression if the patch will enter kconfig.
for sure we need a test with XDG env set to a value, and one where XDG is not set. To test both ways.


> On März 24, 2016, 8:16 vorm., David Faure wrote:
> > autotests/kconfigtest.cpp, line 538
> > <https://git.reviewboard.kde.org/r/127462/diff/1/?file=453758#file453758line538>
> >
> >     writableLocaion, not displayName.
> >     
> >     This shows the limitations of a unittest that uses the same code in the code and in the test. If both are wrong, the test still passes :-)

Do you have a better solution for getting away from "a unittest that uses the same code" in this case?


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review93914
-----------------------------------------------------------


On März 22, 2016, 3:23 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> -----------------------------------------------------------
> 
> (Updated März 22, 2016, 3:23 nachm.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> According to freedesktop specification XDG_*_HOME env varaible should be
> replaced, if they are not setted with default values.
> 
> https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
> 
> as qgetenv only calls getenv, so no path is traslated to it default values. So we have to add this replacement manually. This would help to use XDG_*_HOME more often in configfiles.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> -------
> 
> Adding tests for XDG_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160324/e362e788/attachment.html>