Review Request 127469: Use QQuickWidget for QML KCMs

[David Rosca]

> On March 23, 2016, 12:07 p.m., Marco Martin wrote:
> > In theory using QQuickWidget is the correct way, but...
> > That widget is really not reliable, it has a structural (and probably unfixable at least on x11) problem in which anybody calling winId() anywhere on any window on the application will turn all QQuickWidgets in black rectangles for the whole application lifecycle.
> > 
> > since systemsettings loads a lot of random c++ code from plugins, we can't ensure this will not happen.
> 
> Aleix Pol Gonzalez wrote:
>     Maybe QQuickWidget can be fixed? If it works here, there must be a way to get QQuickWidget to work.

It only turns black when calling winId() on the QQuickWidget, calling it on any other widgets is not an issue (in this case Qt::AA_DontCreateNativeWidgetSiblings probably helps, but it seems to work fine even without it).
We can't ensure it won't happen, but it is highly unlikely as this QQuickWidget is not a window.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review93895
-----------------------------------------------------------


On March 23, 2016, 10:29 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
>     https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> -------
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160323/d8d48360/attachment.html>