Review Request 127424: KCompletionBox popup gets full window decoration on Windows
Thomas Lübking
thomas.luebking at gmail.com
Sun Mar 20 09:38:59 UTC 2016
> On März 20, 2016, 4:22 vorm., Anthony Fieroni wrote:
> > src/kcompletionbox.cpp, line 282
> > <https://git.reviewboard.kde.org/r/127424/diff/1/?file=453612#file453612line282>
> >
> > After show, call activateWindow(), even you can call raise()
The window shall *not* be activated.
One could probably call activateWindow() on the parenting/filtered window and raise the completionbox afterwards (because it still needs to be above the main window), but I frankly ceased to care.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93749
-----------------------------------------------------------
On März 19, 2016, 8:56 nachm., Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> -----------------------------------------------------------
>
> (Updated März 19, 2016, 8:56 nachm.)
>
>
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags were change from Qt::ToolTip to Qt::Window.
>
> As consequence, the completion popup of the Kate command line gets a full window decoration, which is obviously wrong, see attached screenshot.
>
> Changing the type to Qt::Popup shows the proper popup, but key presses are not forwarded, so typing is not possible, and additionally, on losing focus the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
>
> Better fixes are of course welcome ;) Any ideas?
>
>
> Diffs
> -----
>
> src/kcompletionbox.cpp 005aff8
>
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
>
>
> Testing
> -------
>
> Works on Windows as expected.
>
>
> File Attachments
> ----------------
>
> Completion Popup
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
>
>
> Thanks,
>
> Dominik Haumann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160320/c0b3c346/attachment.html>
More information about the Kde-frameworks-devel
mailing list