Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.

David Faure faure at kde.org
Sun Mar 20 09:03:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127428/
-----------------------------------------------------------

(Updated March 20, 2016, 9:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 5901b41b8ca431c6da5389d098aca6b7bc55b9eb by David Faure to branch master.


Repository: kemoticons


Description
-------

Noticed in the CI which says: Invalid plugin factory for "kf5/emoticonsthemes/kde"


Diffs
-----

  src/core/kemoticons.cpp 87e4a1116b634fdae33f42112b870c5eb1c204d0 

Diff: https://git.reviewboard.kde.org/r/127428/diff/


Testing
-------

Removing lib64/plugins/kf5/emoticonsthemes/kde.so locally, I got the crash too, this fixes it.

Of course the unittest fails then, as expected, it just doesn't crash anymore.

I think some env vars are missing in Jenkins....


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160320/bd3cf277/attachment.html>


More information about the Kde-frameworks-devel mailing list