Review Request 127424: KCompletionBox popup gets full window decoration on Windows
Thomas Lübking
thomas.luebking at gmail.com
Sat Mar 19 13:22:40 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
-----------------------------------------------------------
"Loose focus" is the complete wrong concept anyway.
It makes kickoff and various other plasmashell elements barely usable w/ any but the click-to-focus policy (implicit hide)
Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should be Qt::BypassWindowManagerHint anyway)
PS: it's rather worrysome that Qt::Popup fails since it *is* set for the QComboBox dropdown. May point an implementation weakeness/bug in this class.
- Thomas Lübking
On März 19, 2016, Mittag, Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> -----------------------------------------------------------
>
> (Updated März 19, 2016, Mittag)
>
>
> Review request for KDE Frameworks, kwin and Marco Martin.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags were change from Qt::ToolTip to Qt::Window.
>
> As consequence, the completion popup of the Kate command line gets a full window decoration, which is obviously wrong, see attached screenshot.
>
> Changing the type to Qt::Popup shows the proper popup, but key presses are not forwarded, so typing is not possible, and additionally, on losing focus the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
>
> Better fixes are of course welcome ;) Any ideas?
>
>
> Diffs
> -----
>
> src/kcompletionbox.cpp 005aff8
>
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
>
>
> Testing
> -------
>
> Works on Windows as expected.
>
>
> File Attachments
> ----------------
>
> Completion Popup
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
>
>
> Thanks,
>
> Dominik Haumann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160319/aee51834/attachment.html>
More information about the Kde-frameworks-devel
mailing list