Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

[Anthony Fieroni]

> On Март 12, 2016, 5:07 след обяд, Christoph Feck wrote:
> > Can someone confirm the issue is still present with Qt 5.6?
> > 
> > Unless it is, I suggest to not work around the Qt bug, because the release of Qt 5.6 is imminent and this fix does not reach our users earlier.
> 
> Luigi Toscano wrote:
>     Don't we still support older version of Qt?

I can confirm this patch is *NOT* needed on Qt 5.6, it works correct.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127353/#review93449
-----------------------------------------------------------


On Март 12, 2016, 4:53 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127353/
> -----------------------------------------------------------
> 
> (Updated Март 12, 2016, 4:53 след обяд)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 358977
>     https://bugs.kde.org/show_bug.cgi?id=358977
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> QAction->setVisible(false) not work in init function, adding timer to trigger visability
> 
> 
> Diffs
> -----
> 
>   src/knewpasswordwidget.cpp 72748d6 
>   src/kpassworddialog.cpp 082929c 
> 
> Diff: https://git.reviewboard.kde.org/r/127353/diff/
> 
> 
> Testing
> -------
> 
> Or we can make action disabled, looks candy.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/0eb3f420-553f-497e-806b-15a373bdbe32__Screenshot_20160312_110707.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/2feb37c4-143f-4560-8b97-963b2f4f1737__Screenshot_20160312_111731.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160319/f9f14fc3/attachment.html>