Review Request 127418: Set text on QCheckbox widget rather than using a separate label

David Edmundson david at davidedmundson.co.uk
Fri Mar 18 01:51:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127418/
-----------------------------------------------------------

(Updated March 18, 2016, 2:51 a.m.)


Review request for KDE Frameworks.


Bugs: 245580
    https://bugs.kde.org/show_bug.cgi?id=245580


Repository: kio


Description
-------

This fixes (amongst other focus bugs) the label having the right
enabled effect if the permissions are not editable.

CCBUG: 245580


Diffs
-----

  src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 

Diff: https://git.reviewboard.kde.org/r/127418/diff/


Testing
-------

Opened kpropertiesdialog on a folder and a file

Faked being a file system without ACL (by adding && false) into line 2128 so that we see the full grid of options

Opened kpropertiesdialog on a folder and a file


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160318/5146504d/attachment.html>


More information about the Kde-frameworks-devel mailing list