Review Request 127409: Make sure we're not forcing the window to be created prematurely
David Edmundson
david at davidedmundson.co.uk
Fri Mar 18 01:47:44 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/#review93672
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On March 17, 2016, 2:13 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127409/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 2:13 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Only update the properties that require a winId when visible, otherwise let updateVisibility() take care about them.
>
>
> Diffs
> -----
>
> src/plasmaquick/dialog.cpp 7bb63c5
>
> Diff: https://git.reviewboard.kde.org/r/127409/diff/
>
>
> Testing
> -------
>
> I don't get platform creations being forced on gdb.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160318/fe471f52/attachment.html>
More information about the Kde-frameworks-devel
mailing list