Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/#review93581
-----------------------------------------------------------




mtp/devicecache.cpp (line 113)
<https://git.reviewboard.kde.org/r/127386/#comment63806>

    int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, solidDevNum);
    
    this line looks important
    
    from what I can tell, this patch simply tries to use every possible device as an MTP client skipping all the checks.
    
    I would have though that would have had some downsides.
    
    Does viewing mtp:/ list any extra entries?


- David Edmundson


On March 15, 2016, 5:52 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127386/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 5:52 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
> 
> 
> Bugs: 325335
>     https://bugs.kde.org/show_bug.cgi?id=325335
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp.
> 
> It seems the device is listed but dropped for some reason. This issues exists for quite a long time (also in KDE 4.x), and some people provided this patch (from bug #325335).
> 
> I personally cannot test this patch, as I don't own a Windows Phone.
> 
> However, given this patch works successfully for at least some users (see also https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/), I think we at least should give it a try.
> 
> Adding group 'kdeframeworks' to reach a broader audience.
> 
> Would be cool to get a proper review for this patch, or even someone who owns such a device!
> 
> 
> Diffs
> -----
> 
>   mtp/devicecache.cpp 8c5c7cf 
> 
> Diff: https://git.reviewboard.kde.org/r/127386/diff/
> 
> 
> Testing
> -------
> 
> Compiles...
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160316/2b91525b/attachment.html>