Review Request 127380: More conservative approach to saving some disk accesses

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127380/#review93538
-----------------------------------------------------------



Why don't you just make use of the posix stat call? I know the QFileInfo::lastModified() has some issues as David described in your last approach, but why not use the plain simple stat function?
http://man7.org/linux/man-pages/man2/stat.2.html

st_mtim specifically, which is described as:

       The field st_mtime is changed by file modifications, for example, by
       mknod(2), truncate(2), utime(2), and write(2) (of more than zero
       bytes).  Moreover, st_mtime of a directory is changed by the creation
       or deletion of files in that directory.  The st_mtime field is not
       changed for changes in owner, group, hard link count, or mode.

Which is exactly what you want, should still be working in a cross platform manner and gives you the optimizations you initially had without the issue you had, right?

Just my 2 cents :)

- Mark Gaiser


On mrt 15, 2016, 1:52 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127380/
> -----------------------------------------------------------
> 
> (Updated mrt 15, 2016, 1:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> My previous approach to KIconThemes felt like a dead end, I decided I'll take a more conservative approach. Here's a first step.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 61e81f6 
>   autotests/kiconloader_benchmark.cpp PRE-CREATION 
>   src/kiconloader.cpp 75ab482 
>   src/kicontheme.cpp 0996054 
> 
> Diff: https://git.reviewboard.kde.org/r/127380/diff/
> 
> 
> Testing
> -------
> 
> Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 before= 17% less QFile::exists
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160315/8685b126/attachment.html>