Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Mar 14 13:11:59 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127348/#review93506
-----------------------------------------------------------
Ship it!
Thank you!
- Aleix Pol Gonzalez
On March 14, 2016, 1:55 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127348/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 1:55 p.m.)
>
>
> Review request for KDE Frameworks and KDEPIM.
>
>
> Repository: kpeople
>
>
> Description
> -------
>
> For single contact without any person, PersonData does not work. This uses the contact uri as a person uri in that case, making things work. It also mirrors what PersonsModel does.
>
>
> Diffs
> -----
>
> autotests/persondatatests.cpp 5f7cabd
> src/persondata.cpp 4586bac
>
> Diff: https://git.reviewboard.kde.org/r/127348/diff/
>
>
> Testing
> -------
>
> PersonData returns correct data
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160314/90f97c3d/attachment.html>
More information about the Kde-frameworks-devel
mailing list