Review Request 127353: [KPasswordDialog] echo icon is drawn over clear button

[Elvis Angelaccio]

> On March 12, 2016, 9:44 a.m., Elvis Angelaccio wrote:
> > Please note that the bug is in QLineEdit: https://bugreports.qt.io/browse/QTBUG-48806
> > 
> > What happens to your workaround if you run Qt 5.6?
> 
> Anthony Fieroni wrote:
>     Current code wants to hide echo icon on startup, no? Nothings changed, just visabity working now.

Yeah sorry, I didn't initially realized that you are just delaying the setVisible(false) call.
Looks good to me, but what about adding a comment "This won't be needed anymore with Qt 5.6"?


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127353/#review93433
-----------------------------------------------------------


On March 12, 2016, 9:31 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127353/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 9:31 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> QAction->setVisible(false) not work in init function, addig timer to trigger visability
> 
> 
> Diffs
> -----
> 
>   src/knewpasswordwidget.cpp 72748d6 
>   src/kpassworddialog.cpp 082929c 
> 
> Diff: https://git.reviewboard.kde.org/r/127353/diff/
> 
> 
> Testing
> -------
> 
> Or we can make action disabled, looks candy.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/0eb3f420-553f-497e-806b-15a373bdbe32__Screenshot_20160312_110707.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/2feb37c4-143f-4560-8b97-963b2f4f1737__Screenshot_20160312_111731.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160312/76a1110f/attachment.html>