Review Request 127237: Fix crash in kmore tools on Windows

Kåre Särs kare.sars at iki.fi
Fri Mar 11 20:43:27 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127237/
-----------------------------------------------------------

(Updated March 11, 2016, 12:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Gregor Mi.


Changes
-------

Submitted with commit def01c5bb668a284d9db48c4c402adc8268b895a by Kåre Särs to branch master.


Repository: knewstuff


Description
-------

On Windows we sometimes get null-pointers in stead of pointers to KMoreToolsService. This patch adds checks for null-pointers in those places that made Kate crash in the project plugin and adds a nullptr check before adding them to the list.


Diffs
-----

  src/kmoretools/kmoretoolsmenufactory.cpp 30f4d02 
  src/kmoretools/kmoretoolspresets.cpp 2405321 

Diff: https://git.reviewboard.kde.org/r/127237/diff/


Testing
-------

Compiled and run on windows. No crashes in Kate when right-clicking files in the project plugin.


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160311/6cf0f285/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list