Review Request 127271: Disable session restore for kwalletd5

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93398
-----------------------------------------------------------



Please revert to the initial patch, I should have given it a "ship it" to avoid any confusion. I was just wondering about the other daemons.


src/runtime/kwalletd/main.cpp (line 210)
<https://git.reviewboard.kde.org/r/127271/#comment63673>

    I don't see what this is doing here. That's about making sure that session management (at the time of logging out) will not forcefully close the open windows before they get a chance to be properly saved. There is no open window in kwalletd and no saving at all, that's what your patch is all about.
    
    Basically, with RestartNever, this is completely unnecessary.


- David Faure


On March 6, 2016, 7:01 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> I notice a kwalletd5 with "-session ....." in its command line started on my desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let session manager to restore it.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> -------
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160310/ab065147/attachment.html>