Review Request 127334: Fix build with -DBUILD_TEST=TRUE
Heiko Becker
heirecka at exherbo.org
Thu Mar 10 19:46:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127334/
-----------------------------------------------------------
(Updated March 10, 2016, 7:46 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Dario Freddi and Martin Gräßlin.
Changes
-------
Submitted with commit 1b4b6b721d4f853f0ef93808ccf6648f3a7b3b9f by Heiko Becker to branch master.
Repository: polkit-qt-1
Description
-------
Otherwise it fails with "test/test.cpp:49:14: error: 'qVariantValue'
was not declared in this scope". qVariantValue is a obsolete
workaround for MSVC 6, which was released 1998 and thus seems ancient
enough to change this.
Diffs
-----
test/test.cpp afb7f64333e1122d86d2692f9cbaa94a08bec800
Diff: https://git.reviewboard.kde.org/r/127334/diff/
Testing
-------
Builds at least. The test doesn't run successfully though (Totals: 6 passed, 3 failed, 0 skipped, 0 blacklisted). I doubt it did before. There's also no target to run it.
Thanks,
Heiko Becker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160310/cad668f6/attachment.html>
More information about the Kde-frameworks-devel
mailing list