Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

[Martin Klapetek]

> On March 10, 2016, 2:56 p.m., Martin Klapetek wrote:
> > Can you please explain clearly the problem this should solve and explain more clearly how this solves that problem?
> > 
> > Also I see with your every review "I have not tested this", please do test your patches before posting them.
> 
> Anthony Fieroni wrote:
>     Looks like my English is really bad :)
>     auto n = new KNotification;
>     n->close(); <--------------- ref = 0, closed() is not emitted, deleteLater() is not called => leak

This is a wrong fix for it then. Proper fix would be to init d->id to -1 rather than 0, which I have now done, but I'll keep testing it for a bit.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127326/#review93387
-----------------------------------------------------------


On March 10, 2016, 10:28 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127326/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 10:28 a.m.)
> 
> 
> Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> If KNotification is not notified, he don't ref() notification, if call close() on it cause a leak, emu closed() is not triggered.
> https://git.reviewboard.kde.org/r/127318/
> 
> 
> Diffs
> -----
> 
>   src/knotification.cpp 17b0be2 
> 
> Diff: https://git.reviewboard.kde.org/r/127326/diff/
> 
> 
> Testing
> -------
> 
> No real test, just blame me if i'm not right.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160310/5cff57cf/attachment.html>