Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

Anthony Fieroni bvbfan at abv.bg
Thu Mar 10 09:28:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127326/
-----------------------------------------------------------

Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and Martin Klapetek.


Repository: knotifications


Description
-------

If KNotification is not notified, he don't ref() notification, if call close() on it cause a leak, emu closed() is not triggered.
https://git.reviewboard.kde.org/r/127318/


Diffs
-----

  src/knotification.cpp 17b0be2 

Diff: https://git.reviewboard.kde.org/r/127326/diff/


Testing
-------

No real test, just blame me if i'm not right.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160310/a4bf4ba5/attachment.html>


More information about the Kde-frameworks-devel mailing list