Review Request 127205: Add stubs to allow compilation on Android.

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127205/#review93290
-----------------------------------------------------------


Fix it, then Ship it!




Looks good


src/lib/util/kuser_unix.cpp (line 38)
<https://git.reviewboard.kde.org/r/127205/#comment63616>

    I'd say these should be static inline so that the compiler doesn't need to emit a copy of the function in the library.


- Alex Richardson


On March 2, 2016, 8:18 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127205/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 8:18 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Android's libc implementation lacks several features required by the Unix backend implementation. This patch allows compilation by adding stubs for all missing struct members and functions. Result of this patch is that on Android KUser returns empty GUID and UID lists.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt da67071 
>   src/lib/CMakeLists.txt cf57f09 
>   src/lib/util/kuser_unix.cpp de5acde 
> 
> Diff: https://git.reviewboard.kde.org/r/127205/diff/
> 
> 
> Testing
> -------
> 
> Compilation tested on Linux and Android.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160308/930b620b/attachment.html>