Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127251/
-----------------------------------------------------------

(Updated März 7, 2016, 2:35 nachm.)


Review request for KDE Frameworks and Vishesh Handa.


Changes
-------

Remove cruft from other review


Bugs: 345750
    https://bugs.kde.org/show_bug.cgi?id=345750


Repository: kunitconversion


Description
-------

QNetworkReply does not implement waitForReadyRead

Also, the code never actually created the cache dir it was trying to create a file in.


Diffs (updated)
-----

  src/currency.cpp 3b99644 

Diff: https://git.reviewboard.kde.org/r/127251/diff/


Testing
-------

Works now. It's downloaded once and then taken from cache file in ~/.local/share/libkunitconversion/currency.xml

Given it's a Tier 2 framework doesn't make sense to add KIO now, also failed to reproduce the crashes mentioned in the code.

Tests pass (only if I run them on English locale btw)

Obviously not happy with this being sync but alas that's how the API works.

Not sure if this is a KRunner bug or KUnitConverison but if I enter "5 USD" it converts fine, if I enter "5 usd" it returns zero for all the currencies it converted to.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160307/5a3f2b1d/attachment.html>