Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

Andre Heinecke aheinecke at intevation.de
Mon Mar 7 12:32:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/
-----------------------------------------------------------

(Updated March 7, 2016, 12:32 p.m.)


Review request for KDE Frameworks and Localization and Translation (l10n).


Changes
-------

Added ifndef Q_OS_UNIX around fallback.


Repository: ki18n


Description
-------

The intention for this patch is to fix the inital Language selection for Windows where the environment variables used in Ki18n are not set.
This is not a fix for a regression in Ki18n, afaik this never worked on Windows, we had some hacks in Gpg4win to write the language into kdeglobals during installation in kde4 times.

I don't think this needs to be ifdefed because it only appends so previous language selection is not affected.


Diffs (updated)
-----

  src/klocalizedstring.cpp b24fe9b 

Diff: https://git.reviewboard.kde.org/r/127275/diff/


Testing
-------

Tested on a german Windows system and got a "de" localized application.


Thanks,

Andre Heinecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160307/b119e781/attachment.html>


More information about the Kde-frameworks-devel mailing list