Review Request 127191: KCompletionBox should *not* be a tooltip
Marco Martin
notmart at gmail.com
Mon Mar 7 10:48:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127191/#review93251
-----------------------------------------------------------
any updates?
- Marco Martin
On Feb. 26, 2016, 2:18 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127191/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 2:18 p.m.)
>
>
> Review request for KDE Frameworks and kwin.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> KCompletionbox it's actually more of a combobox popup than a tooltip.
> this sets it the proper type (unfortunately with an hack due the type not being available to Qt::WindowFlags)
>
> without this, the new morphingpopups KWin effect will animate completion boxes (such as in file open dialog, kate, dolphin adress bar etc)
>
>
> Diffs
> -----
>
> src/kcompletionbox.cpp 99afc8e
>
> Diff: https://git.reviewboard.kde.org/r/127191/diff/
>
>
> Testing
> -------
>
> Same behavior, due to the Window and bypasswindowmanager that are those two that made the desired behavior when tooltip was picked
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160307/d8a4d1af/attachment.html>
More information about the Kde-frameworks-devel
mailing list