Review Request 127271: Disable session restore for kwalletd5

[David Faure]

> On March 5, 2016, 9:27 a.m., David Faure wrote:
> > Looks good and more portable than the
> >     qunsetenv("SESSION_MANAGER");
> > which is used in many other places...
> > 
> > Not sure both connects are necessary though?
> 
> Xuetian Weng wrote:
>     This is not to disable the whole session manager thing, but just disable the restore. So session manager is still able to terminate kwalletd.

Ah. Do you mean that with this code, the process is terminated more gracefully than with the qunsetenv solution which e.g. kiod or kded use (I guess they simply die with an X error when Xorg disappears). Sounds like another reason for this approach indeed, although it probably doesn't make much difference from a user's perspective [other than portability of course].

Sounds like we should apply the same code in all these:

kded/src/kded.cpp:682:    qunsetenv("SESSION_MANAGER");
kdesu/src/ptyprocess.cpp:305:    unsetenv("SESSION_MANAGER");
kglobalaccel/src/runtime/main.cpp:56:    qunsetenv( "SESSION_MANAGER" );
kinit/src/klauncher/klauncher_main.cpp:153:    qunsetenv("SESSION_MANAGER");
kio/src/kiod/kiod_main.cpp:89:    qunsetenv("SESSION_MANAGER"); 

This also makes me wonder what happens to non-GUI daemons, i.e. what will terminate them when logging out... (all of the above are GUI enabled, but e.g. kio_http_cache_cleaner is core-only).


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93187
-----------------------------------------------------------


On March 3, 2016, 8:34 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> I notice a kwalletd5 with "-session ....." in its command line started on my desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let session manager to restore it.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> -------
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160305/6e6f4c2c/attachment.html>