Review Request 127266: Fix build with MinGW on Windows

[Thomas Friedrichsmeier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127266/
-----------------------------------------------------------

(Updated March 5, 2016, 10:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Changes
-------

Submitted with commit 8f58ddf1cfb053147d6d12a3e13ea33b079072ef by Thomas Friedrichsmeier to branch master.


Repository: khtml


Description
-------

Fix building with MinGW on Windows, by removing conflicting FOCUS_EVENT (also "OPTIONAL" and "CreateEvent") defines. Note that there already is a similar #undef in dom2_eventsimpl.h, but this is ineffective, if the Windows defines are added after dom2_eventsimpl.h was (first) included.

First, I tried solving this by shuffling around includes, but gave up on this path after quite some trial and error. (Main route of inclusion for windows.h seems to be khtml_part.h -> parts/browserextension.h -> Platform includes.)


Diffs
-----

  src/ecma/kjs_dom.cpp e3fedad 
  src/ecma/kjs_html.cpp cc3c08a 
  src/html/html_baseimpl.cpp 539681c 
  src/html/html_elementimpl.cpp 7569192 
  src/html/htmlparser.cpp 064b99b 
  src/xml/dom_docimpl.cpp 4f0be5c 

Diff: https://git.reviewboard.kde.org/r/127266/diff/


Testing
-------

Now builds with MinGW.


Thanks,

Thomas Friedrichsmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160305/ad1921d0/attachment-0001.html>