Review Request 127281: [kio-extras] Audio (id3) thumbnailer

[Kai Uwe Broulik]

> On März 4, 2016, 10:18 nachm., Dāvis Mosāns wrote:
> > do you know about https://github.com/eplightning/audiothumbs-frameworks ? it works fine with Qt5/KF5 and I've been using to for months. I wonder if there would be some better way with either merging it all in here or something without duplicating code. Currently it supports more formats than this RR gives.

I was not aware of that; indeed perhaps we could upstream this?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127281/#review93176
-----------------------------------------------------------


On März 4, 2016, 9:43 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127281/
> -----------------------------------------------------------
> 
> (Updated März 4, 2016, 9:43 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> This is basically a port and cleanup of the Audio Thumbnailer to KF5, I find it useful to ship this by default. Minus the FLAC part as I don't have any FLAC stuff :)
> 
> 
> Diffs
> -----
> 
>   thumbnail/CMakeLists.txt 4addb26 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127281/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/04/b099ec03-7fa7-4ed3-91c4-bc55c62c72ca__Screenshot_20160304_224228.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160304/3f644053/attachment-0001.html>