Review Request 127280: Fix memory leak in icon item test

David Rosca nowrep at gmail.com
Fri Mar 4 20:48:01 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127280/#review93175
-----------------------------------------------------------



There is a cleanup that deletes all children, I don't think this is needed.

- David Rosca


On March 4, 2016, 8:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127280/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 8:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Not a big problem as it's only a test, but it will allow us to valgrind
> it in future.
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.cpp 8d3f494a1ff6a09e7b4c4738aa69588c371678c8 
> 
> Diff: https://git.reviewboard.kde.org/r/127280/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160304/583fbc55/attachment.html>


More information about the Kde-frameworks-devel mailing list