Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127270/
-----------------------------------------------------------

(Updated March 4, 2016, 12:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 1b21758570e95d36d477968e6b626c0850f85b44 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

IconItem handled both QOixmaps and QImages as a source.

QVariant(somePixmap).canConvert<QImage>() returns true so one of the
two code paths isn't executed. Given converting between the two is
practically free, we don't need two code paths.


Diffs
-----

  src/declarativeimports/core/iconitem.cpp 1e98e4952656756bf320c8974e075441590fad4f 

Diff: https://git.reviewboard.kde.org/r/127270/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160304/c9daf99e/attachment.html>