Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Anthony Fieroni]

> On Март 3, 2016, 11:26 след обяд, Thomas Lübking wrote:
> > src/kstatusnotifieritem.cpp, line 425
> > <https://git.reviewboard.kde.org/r/127216/diff/2/?file=446044#file446044line425>
> >
> >     I assume this is the dealbreaker for the failing apps.
> >     This entire "restore position" mumbojumbo only makes sense if the associated widget can change, in which case this will break the positioning.
> >     
> >     => only store on minimizing and see what happens.
> 
> Anthony Fieroni wrote:
>     But if you have more than one minimized app, result will be the same, about me.

Tested, it works the same way. Placement depends on WM. Martin wants to restore last position.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review93133
-----------------------------------------------------------


On Фев. 29, 2016, 7:18 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> -----------------------------------------------------------
> 
> (Updated Фев. 29, 2016, 7:18 преди обяд)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin Klapetek.
> 
> 
> Bugs: 356523
>     https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -----
> 
>   src/kstatusnotifieritem.cpp cf3e7b5 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> -------
> 
> Tested on pixel ration = 1
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160303/46655f46/attachment.html>