Review Request 127240: [Applet] Don't crash on remove panel
Anthony Fieroni
bvbfan at abv.bg
Thu Mar 3 21:52:57 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127240/
-----------------------------------------------------------
(Updated Март 3, 2016, 11:52 след обяд)
Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco Martin.
Changes
-------
3th parameter can't be *this*, i'm not Qt dev without it, all compiles and works as expected. David, i can't compile it when i make the patch.
Bugs: 345723
http://bugs.kde.org/show_bug.cgi?id=345723
Repository: plasma-framework
Description
-------
Stop timer is any case, if you don't want *this* to be nullptr
Diffs (updated)
-----
src/plasma/private/applet_p.cpp 38d486a
Diff: https://git.reviewboard.kde.org/r/127240/diff/
Testing
-------
Still not tested, but look good for me.
Thanks,
Anthony Fieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160303/99e1eb0b/attachment.html>
More information about the Kde-frameworks-devel
mailing list