Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11
Martin Klapetek
martin.klapetek at gmail.com
Thu Mar 3 21:04:02 UTC 2016
> On Feb. 29, 2016, 7:59 p.m., Martin Klapetek wrote:
> > This works in 50% of cases for me. I'm not sure if Quassel and Konversation are doing something special wrt to restoring position but this doesn't fix it.
>
> Anthony Fieroni wrote:
> Can you show simple video? Placement depends on window manager settings and showed windows.
>
> Anthony Fieroni wrote:
> Martin, if you not against this patch i will pish for 5.20. Since Amarok, Akregator, Kmail, Juk, KAlarm, KTimer works as expected and a lot better than current implementation. I never used this 2 apps, share you experience with them.
I'm not entirely sure what do you expect to see but here you go: https://www.dropbox.com/s/ugrl6ev8yzez0zp/vokoscreen-2016-03-03_16-02-02.mkv?dl=0
The minimalization and restoring is done with mouse clicking on the SNI.
That said, if Martin G and/or Thomas approve this patch as the "windows guys", I have nothing against it.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review92926
-----------------------------------------------------------
On Feb. 29, 2016, 6:18 a.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 6:18 a.m.)
>
>
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin Klapetek.
>
>
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Store position of widget before hide it
>
>
> Diffs
> -----
>
> src/kstatusnotifieritem.cpp cf3e7b5
> src/kstatusnotifieritemprivate_p.h 8fdfd4c
>
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
>
>
> Testing
> -------
>
> Tested on pixel ration = 1
>
>
> Thanks,
>
> Anthony Fieroni
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160303/510adadd/attachment.html>
More information about the Kde-frameworks-devel
mailing list