Review Request 126991: Try multiple authentication methods in case of failures

[Krzysztof Nowicki]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126991/
-----------------------------------------------------------

(Updated March 3, 2016, 10:01 p.m.)


Review request for KDE Frameworks and Dawit Alemayehu.


Changes
-------

Add comment explaining separation of auth method name from any optional parameters.


Repository: kio


Description
-------

When authenticating agains a server offering multiple authentication methods make sure to attempt other methods in case the best one fails.
    
This also fixes a connection close issue in the middle of an NTLM authentication dialog due to clearing the password.


Diffs (updated)
-----

  src/ioslaves/http/http.h 621b2c7a957b9bc9cc14ff13ed3c3a72dec38190 
  src/ioslaves/http/http.cpp a84129f1403cbf8b0f86f9fd0354bec90ac5fd39 

Diff: https://git.reviewboard.kde.org/r/126991/diff/


Testing
-------

I have performed testing on an IIS 7.5 server which offered 3 authentication options: Negotiate, NTLM and Basic. Since I have Kerberos configured the original code would only try Negotiate and because it failed it would retry it endlessly. With this patch authentication correctly falls back to NTLM or Basic (if NTLM fails too).


Thanks,

Krzysztof Nowicki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160303/9413eecb/attachment.html>