Review Request 127267: [KPeople] Set a name for the database connection

Aleix Pol Gonzalez aleixpol at kde.org
Thu Mar 3 16:52:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127267/#review93105
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On March 3, 2016, 5:04 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127267/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 5:04 p.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> If the app using KPeople is also using a QSqlDatabse and also
> with a default connection name but different database, Qt will
> reuse the connection and close one database and reopen the other,
> which can cause troubles, especially then when used with QSqlQueryModel.
> 
> 
> Diffs
> -----
> 
>   src/personmanager.cpp 5c2d7af 
> 
> Diff: https://git.reviewboard.kde.org/r/127267/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160303/fe118b8a/attachment.html>


More information about the Kde-frameworks-devel mailing list