Review Request 127245: Fix Kdelibs4 config migration for Windows

Andre Heinecke aheinecke at intevation.de
Thu Mar 3 13:28:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127245/
-----------------------------------------------------------

(Updated March 3, 2016, 1:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit acd2c096632a5ae54b9b2267a7159b0f658c4243 by Andre Heinecke to branch master.


Repository: kcoreaddons


Description
-------

The old config was by default in ~/AppData/Roaming/.kde so on Windows we should look there, too.

The new config location (as used everywhere in KConfig) should be GenericConfigLocation and not ConfigLocation. 
According to http://doc.qt.io/qt-5/qstandardpaths.html this only makes a difference on Windows so I think it's still safe to change this.


Diffs
-----

  src/lib/util/kdelibs4configmigrator.cpp c8560c1 
  src/lib/util/kdelibs4migration.cpp f631efa 

Diff: https://git.reviewboard.kde.org/r/127245/diff/


Testing
-------

On Windows: Made changes to XMLGui rc file and both kleopatra config files with a KDE 4 Kleo. Checked that they were migrated and changes show up.


Thanks,

Andre Heinecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160303/e3a154d0/attachment.html>


More information about the Kde-frameworks-devel mailing list