Review Request 126991: Try multiple authentication methods in case of failures

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126991/#review93084
-----------------------------------------------------------


Fix it, then Ship it!





src/ioslaves/http/http.cpp (line 5371)
<https://git.reviewboard.kde.org/r/126991/#comment63469>

    (I would move that documentation to the enum definition, it explains what the various enum values are, and would be easier to find there)



src/ioslaves/http/http.cpp (line 5422)
<https://git.reviewboard.kde.org/r/126991/#comment63468>

    if (!a || (a && b))
    
    is the same as
    
        if (!a || b)
    
    When you're in the second half, you know that a is true, by definition. So this if statement can (and should imho) be simplified.


- David Faure


On Feb. 29, 2016, 3:10 p.m., Krzysztof Nowicki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126991/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Dawit Alemayehu.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> When authenticating agains a server offering multiple authentication methods make sure to attempt other methods in case the best one fails.
>     
> This also fixes a connection close issue in the middle of an NTLM authentication dialog due to clearing the password.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/http.h 621b2c7a957b9bc9cc14ff13ed3c3a72dec38190 
>   src/ioslaves/http/http.cpp a84129f1403cbf8b0f86f9fd0354bec90ac5fd39 
> 
> Diff: https://git.reviewboard.kde.org/r/126991/diff/
> 
> 
> Testing
> -------
> 
> I have performed testing on an IIS 7.5 server which offered 3 authentication options: Negotiate, NTLM and Basic. Since I have Kerberos configured the original code would only try Negotiate and because it failed it would retry it endlessly. With this patch authentication correctly falls back to NTLM or Basic (if NTLM fails too).
> 
> 
> Thanks,
> 
> Krzysztof Nowicki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160303/2909ece8/attachment-0001.html>