Review Request 127245: Fix Kdelibs4 config migration for Windows

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127245/
-----------------------------------------------------------

(Updated March 2, 2016, 11:04 a.m.)


Review request for KDE Frameworks.


Changes
-------

Use SHGetFolderPath to match behavior of kdelibs4.

Tested this again.


Repository: kcoreaddons


Description
-------

The old config was by default in ~/AppData/Roaming/.kde so on Windows we should look there, too.

The new config location (as used everywhere in KConfig) should be GenericConfigLocation and not ConfigLocation. 
According to http://doc.qt.io/qt-5/qstandardpaths.html this only makes a difference on Windows so I think it's still safe to change this.


Diffs (updated)
-----

  src/lib/util/kdelibs4configmigrator.cpp c8560c1 
  src/lib/util/kdelibs4migration.cpp f631efa 

Diff: https://git.reviewboard.kde.org/r/127245/diff/


Testing
-------

On Windows: Made changes to XMLGui rc file and both kleopatra config files with a KDE 4 Kleo. Checked that they were migrated and changes show up.


Thanks,

Andre Heinecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160302/5d01e6d5/attachment-0001.html>