Review Request 127215: simplify code, reduce pointer dereferences
David Faure
faure at kde.org
Wed Mar 2 08:22:19 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127215/#review93056
-----------------------------------------------------------
Ship it!
Well, the Qt bug isn't invalid, there's a bug if the documentation is incomplete....
Thanks for the patch, looks good now.
- David Faure
On Feb. 29, 2016, 12:27 p.m., Nick Shaforostoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127215/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 12:27 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> Changes are mostly related to containers/iterators, but there are also few QString related optimizations
>
> note that i have made a switch from QLinkedList to just QList because it performs better for T=<void*>
> also i have changed QStringList to QSet<QString> in one place to make the code run faster
>
>
> Diffs
> -----
>
> src/services/kservice.cpp c75bce2
> src/services/kservicetype.cpp 2a73ccd
> src/sycoca/kbuildmimetypefactory.cpp 340f76a
> src/sycoca/kbuildservicefactory.cpp a74f2e8
> src/sycoca/kbuildsycoca.cpp e99e906
> src/sycoca/kmimeassociations.cpp 9423b27
> src/sycoca/ksycocadict.cpp f33d01a
> src/sycoca/ksycocafactory.cpp e410581
> src/sycoca/ksycocautils_p.h 8db26b0
>
> Diff: https://git.reviewboard.kde.org/r/127215/diff/
>
>
> Testing
> -------
>
> all tests pass, except kmimeassociationstest (fakeApplicationService is NULL), but it fails also without my changes
>
>
> Thanks,
>
> Nick Shaforostoff
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160302/ff5091b4/attachment.html>
More information about the Kde-frameworks-devel
mailing list