Review Request 127240: [Applet] Don't crash on remove panel

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127240/#review93000
-----------------------------------------------------------



Right place, I think we can simþlify the fix though.


src/plasma/private/applet_p.cpp (line 301)
<https://git.reviewboard.kde.org/r/127240/#comment63423>

    we can make this autodisconnect if "this" gets deleted.
    
    Change to
    
    connect(deleteNotification.data(), &KNotification::closed, this, [=]() {}
    
    the extra 3rd parameter "this" means that the connection will be removed when this gets deleted.
    
    It's safer this way as that handles the containment beind deleted for any other reason.



src/plasma/private/applet_p.cpp (line 321)
<https://git.reviewboard.kde.org/r/127240/#comment63424>

    and here.


- David Edmundson


On March 1, 2016, 2:30 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127240/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 2:30 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco Martin.
> 
> 
> Bugs: 345723
>     http://bugs.kde.org/show_bug.cgi?id=345723
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Stop timer is any case, if you don't want *this* to be nullptr
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/applet_p.cpp 38d486a 
> 
> Diff: https://git.reviewboard.kde.org/r/127240/diff/
> 
> 
> Testing
> -------
> 
> Still not tested, but look good for me.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160301/5ecf8bf9/attachment-0001.html>