Review Request 127205: Add stubs to allow compilation on Android.

[Alex Richardson]

> On March 1, 2016, 12:26 a.m., Aleix Pol Gonzalez wrote:
> > src/lib/CMakeLists.txt, line 116
> > <https://git.reviewboard.kde.org/r/127205/diff/1/?file=445780#file445780line116>
> >
> >     Why does pthread make a difference?
> 
> Andreas Cord-Landwehr wrote:
>     Bionic provides native built-in support for (limited set of) pthread functionality. So no linking is required:
>     
>     http://mobilepearls.com/labs/native-android-api/#pthreads

Should be possible to use the CMake builtin `find_package(Threads)` and link to `Threads::Threads` instead of using `pthread` directly. We might even be able to get rid of the if(WIN32) this way, but I haven't got a Windows system to test.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127205/#review92959
-----------------------------------------------------------


On Feb. 28, 2016, 10:14 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127205/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 10:14 a.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Android's libc implementation lacks several features required by the Unix backend implementation. This patch allows compilation by adding stubs for all missing struct members and functions. Result of this patch is that on Android KUser returns empty GUID and UID lists.
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt cf57f0947f13b126f658774209363480013a2e2a 
>   src/lib/util/kuser_unix.cpp de5acde07f4cb8425f03c455bc55d03dfd2579e9 
> 
> Diff: https://git.reviewboard.kde.org/r/127205/diff/
> 
> 
> Testing
> -------
> 
> Compilation tested on Linux and Android.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160301/a4506202/attachment.html>