Review Request 128317: Make the download dialog fail when *all* categories are missing, not just one

Jeremy Whiting jpwhiting at kde.org
Wed Jun 29 14:23:51 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128317/#review96956
-----------------------------------------------------------


Ship it!




Ship It!

- Jeremy Whiting


On June 29, 2016, 5:27 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128317/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 5:27 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> the recent change ed0a1be18ec5b421fc1319d2a28f118d9ea324b9 made the download dialog fail if a category is not found.
> 
> this fixes the dialog showing completely unrelated stuff, but it's too much.
> if even just one category is available, the safest way is to show whatever of the available categories was found.
> the new server will have some category less (for instance most of the categories like "KDE Wallpaper 800x600" will go, so in order to be compatible with old clients, it needs to show content even if one of the categories are available)
> 
> 
> Diffs
> -----
> 
>   src/attica/atticaprovider.cpp ad506cd 
> 
> Diff: https://git.reviewboard.kde.org/r/128317/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160629/b9110f86/attachment.html>


More information about the Kde-frameworks-devel mailing list