Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128307/#review96933
-----------------------------------------------------------



The reason doesn't make too much sense - with Qt 5.6 or higher we're disabling high DPI with the setAttribute rather than qunsetenv

- David Edmundson


On June 28, 2016, 4:22 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128307/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 4:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This prevents kcmshell5 from inheriting the application's environment, namely Plasma disabling Qt's high dpi scaling.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt f12474d 
>   src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp 809de44 
> 
> Diff: https://git.reviewboard.kde.org/r/128307/diff/
> 
> 
> Testing
> -------
> 
> I now get properly scaled config dialogs for power management and user settings
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160628/5a48e1f1/attachment.html>