Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128243/
-----------------------------------------------------------

(Updated June 26, 2016, 11:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

Submitted with commit be4f8d73c3090bbb5cad8d7e590f54b7068bf6a7 by Friedrich W. H. Kossebau to branch master.


Repository: ki18n


Description
-------

This patch fixes two things:

a) `splitLocale(...)` had the wrong order of splitting off modifier and codeset: the old code was first splitting off anything behind "." as charset (which would include the modifier though if present) and only then seeing to split off anything behind "@" as modifier. So with both charset and modifier present this would fail.

b) The locales listed in "LANGUAGE" would be, other than those in "LC_ALL", "LC_MESSAGES" and "LANG", only added as they are to the list of `localeLanguages`, without generating their variants. That seems unbalanced to me, as it would mean KCatalog not properly detecting mo files e.g. in "/usr/share/locale/ru/LC_MESSAGES/" subfolder with "LANGUAGE=ru_RU.UTF-8", "LANG=", "LC_ALL=", "LC_MESSAGES=". Or is that on purpose?


Diffs
-----

  src/klocalizedstring.cpp fc80135 

Diff: https://git.reviewboard.kde.org/r/128243/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160626/c28af426/attachment.html>