Review Request 128250: Silence CMake policy CMP0063 warning also for tests

David Faure faure at kde.org
Sun Jun 26 15:47:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128250/#review96875
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On June 19, 2016, 3:12 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128250/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 3:12 p.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> Despite NO_POLICY_SCOPE being added to the inclusion of
> KDEFrameworkCompilerSettings warnings still appeared because
> ECMAddTests was included before it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e7554a9d6b2292fe27eadd86ea7a62d589db185e 
> 
> Diff: https://git.reviewboard.kde.org/r/128250/diff/
> 
> 
> Testing
> -------
> 
> Warnings disappeared, still builds.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160626/978979fd/attachment.html>


More information about the Kde-frameworks-devel mailing list