Review Request 128289: KIO: add SlaveBase::openPasswordDialogV2 for better error checking.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128289/
-----------------------------------------------------------

(Updated June 26, 2016, 10:17 a.m.)


Review request for KDE Frameworks.


Changes
-------

more porting to V2


Repository: kio


Description
-------

Instead of bool return value, V2 provides an int (job error) return value.
This allows to differenciate between "user canceled" and "error communicating
with kpasswdserver". This is important because upon "user canceled" the job
just finishes silently, so the user thinks the operation succeeded when in fact
it got silently canceled, very dangerous.

The actual communication error dated from when kpasswdserver was in kded
rather than kiod (and on a computer with kded5 not installed), but still,
let's make this robust to avoid a possible data loss situation.


Diffs (updated)
-----

  src/core/global.h aa8082a3d02df5f808e2667cbb6ceaa4131f86ce 
  src/core/job_error.cpp e1feeb5c5803f5302cd853075a66b45742df577b 
  src/core/slavebase.h 77e991e16a256c2ac687760895e4c609e45bf6de 
  src/core/slavebase.cpp d8082bc514eab859a9a6308dae716a23a2b4a895 
  src/ioslaves/ftp/ftp.cpp 335422d6f9a4d60558591b4d4c7835fb55028e57 
  src/ioslaves/http/http.cpp 50f062dc3cb8654da18ebb56d5b92b5330595784 

Diff: https://git.reviewboard.kde.org/r/128289/diff/


Testing
-------

dolphin ftp://foo@davidfaure.fr/

 - when cancelling, no error
 - when uninstalling kiod5 and killing it, "Communication with local password server failed" error appears


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160626/98bd6816/attachment.html>