Review Request 128249: Add switch to disable KParts' handling of window titles
Kevin Funk
kfunk at kde.org
Sat Jun 25 07:26:01 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128249/#review96850
-----------------------------------------------------------
Cool, thanks Andreas!
- Kevin Funk
On June 24, 2016, 8:17 p.m., Andreas Cord-Landwehr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128249/
> -----------------------------------------------------------
>
> (Updated June 24, 2016, 8:17 p.m.)
>
>
> Review request for KDE Frameworks, David Faure and Kevin Funk.
>
>
> Repository: kparts
>
>
> Description
> -------
>
> Applications that use several KParts, like KDevelop, want to do the
> window title settings themselves. To enable that without causing a
> flickering of the KParts' title and the application's title, an
> explicit switch is required, since simply removing the setWindowTitle
> connection after executing a KParts::MainWindow::createGUI(...) call still
> causes an initial flickering, when the GUIActivateEvent is sent in
> the createGUI method. Sending such an event should stay in the createGUI
> method, though.
>
>
> Diffs
> -----
>
> src/mainwindow.h 61a92e3
> src/mainwindow.cpp be0b7dd
> src/part.h 29791d5
>
> Diff: https://git.reviewboard.kde.org/r/128249/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Cord-Landwehr
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160625/2ff452e8/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list