Review Request 128263: Don't include embedded contrainers in containmentAt(pos) - fix crash when adding a system tray.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128263/#review96780
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On June 20, 2016, 8:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128263/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 8:08 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Do to so means the System Tray applet ends up being placed inside the
> system tray container. This causes a recursive parent loop, creating a stack
> overflow every time parent() is called recursively
> 
> This happens whenever one drags a sys tray on the desktop or simply adds
> a new system tray whilst running.
> 
> BUG: 361777
> 
> We also need to do a hack for Plasma/5.7 in plasma-desktop somehow in
> all cases where this is used as this is a huge bug.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp db77db9abeafa508dd26c23710a657584ad1ef0b 
> 
> Diff: https://git.reviewboard.kde.org/r/128263/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160621/fcda3ac0/attachment.html>