Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

Anthony Fieroni bvbfan at abv.bg
Tue Jun 21 04:13:55 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127353/
-----------------------------------------------------------

(Updated Юни 21, 2016, 7:13 преди обяд)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Christoph Feck.


Bugs: 358977
    https://bugs.kde.org/show_bug.cgi?id=358977


Repository: kwidgetsaddons


Description
-------

QAction->setVisible(false) not work in init function, adding timer to trigger visability


Diffs
-----

  src/knewpasswordwidget.cpp 72748d6 
  src/kpassworddialog.cpp 082929c 

Diff: https://git.reviewboard.kde.org/r/127353/diff/


Testing
-------

Or we can make action disabled, looks candy.


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/0eb3f420-553f-497e-806b-15a373bdbe32__Screenshot_20160312_110707.png
After
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/2feb37c4-143f-4560-8b97-963b2f4f1737__Screenshot_20160312_111731.png


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160621/45cd1893/attachment.html>


More information about the Kde-frameworks-devel mailing list