Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

René J.V. Bertin rjvbertin at gmail.com
Sat Jun 18 11:06:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126170/
-----------------------------------------------------------

(Updated June 18, 2016, 4:06 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
-------

Submitted with commit 865efa3af8e76db0012acd5da2a24e71231dad84 by René J.V. Bertin to branch master.


Repository: kded


Description
-------

There should be no reason to build `kded5` as an app bundle on OS X, and with recent feedback in mind I postulated that marking it "nongui" (`ecm_mark_nongui_application`) would be acceptable on other platforms too.

Additionally, `kded5` doesn't have any more reason to appear in the Dock or app switcher, on OS X, so I have added the code to make it an agent.


Diffs
-----

  CMakeLists.txt 72a912c 
  src/CMakeLists.txt 5e95df8 
  src/kded.cpp 8e5f7a9 

Diff: https://git.reviewboard.kde.org/r/126170/diff/


Testing
-------

On OS X 10.9.5 and Linux with Qt 5.6.1 and FWs 5.22.0 .


File Attachments
----------------

example launchctl plist for auto-starting kded5
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/ad67bc98-6e43-47c7-9a0a-dbe7b3b8e11f__org.macports.kded5.plist


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160618/507b19a4/attachment.html>


More information about the Kde-frameworks-devel mailing list