Review Request 128202: Fix problem with install prefix & application bundles
René J.V. Bertin
rjvbertin at gmail.com
Sat Jun 18 09:17:36 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128202/#review96661
-----------------------------------------------------------
AFAIK emerge is not an OS X utility, but something ported from elsewhere. Does it use `-DBUNDLE_INSTALL_DIR` and if not, why?
A few remarks re: kded5. AFAICT this is one of those things that should *not* be installed by each and every application somewhere in its appbundle. I don't think it'd work to run multiple instances of it?
As to finding it: there are 2 ways to address that particular issue. First, kded5 probably ought to be built as a non-app-bundle agent (https://git.reviewboard.kde.org/r/126170/ and the associated https://git.reviewboard.kde.org/r/126161/; kdeinit5/klauncher should probably also *not* be run independently by each and every standalone application that needs them?!).
The second approach concerns all services that are to be auto-started using `.desktop` files or equivalent: those files need to be rewritten so that their Exec key contains an appropriate value. In standalone app bundle builds this could of course also be handled by amending `PATH` as the very first thing when starting up, or even before that by using a wrapper script as the `BundleExec`.
kde-modules/KDEInstallDirs.cmake (line 388)
<https://git.reviewboard.kde.org/r/128202/#comment65315>
Is this going to change anything when you define BUNDLE_INSTALL_DIR on the commandline?
- René J.V. Bertin
On June 18, 2016, 10:28 a.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128202/
> -----------------------------------------------------------
>
> (Updated June 18, 2016, 10:28 a.m.)
>
>
> Review request for KDE Software on Mac OS X, KDE Frameworks, Alex Merry, and David Faure.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Current behavior: Even if you have some own installation prefix like emerge, ECM assumes all stuff in the global /Applications/KDE
> This doesn't work as stuff like kded5 is not found after installation.
> Making it relative resolves this issue.
>
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake f518a4a
>
> Diff: https://git.reviewboard.kde.org/r/128202/diff/
>
>
> Testing
> -------
>
> emerge okular works a bit more with this patch, e.g. kde4support is able to detect kded5.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160618/ee376c1b/attachment.html>
More information about the Kde-frameworks-devel
mailing list