Review Request 127004: OpenFileManagerWindowJob
Kai Uwe Broulik
kde at privat.broulik.de
Fri Jun 17 19:53:59 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127004/
-----------------------------------------------------------
(Updated June 17, 2016, 7:53 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Emmanuel Pescosta and Martin Gräßlin.
Changes
-------
Submitted with commit 84851338b07f904bdcd8318e9635b953424f1484 by Kai Uwe Broulik to branch master.
Repository: kio
Description
-------
This job uses the org.freedesktop.FileManager1 interface to highlight files within a certain folder, useful for eg. downloaded files or a "open containing folder" functionality.
Diffs
-----
src/widgets/CMakeLists.txt fee199f
src/widgets/openfilemanagerwindowjob.h PRE-CREATION
src/widgets/openfilemanagerwindowjob.cpp PRE-CREATION
src/widgets/openfilemanagerwindowjob_p.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127004/diff/
Testing
-------
With Dolphin's org.freedesktop.FileManager1 service installed, I got a file highlighted properly. Without it Dolphin opened the folder without highlighting (KRun fallback).
Not sure what to do with the startup id stuff
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160617/2595886f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list